chrome/browser/extensions/api/metrics_private/metrics_private_api.cc - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

index 60036a2498c182b54b0334b0eb2f381a7421460f..52d21f8caf76bfc9e02873a3b4a35b68e861829e 100644

--- a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

+++ b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

@@ -116,8 +116,7 @@ bool MetricsPrivateRecordValueFunction::RunSync() {

EXTENSION_FUNCTION_VALIDATE(params.get());

// Get the histogram parameters from the metric type object.

- std::string type = api::metrics_private::MetricType::ToString(

- params->metric.type);

+ std::string type = api::metrics_private::ToString(params->metric.type);

base::HistogramType histogram_type(type == "histogram-linear" ?

base::LINEAR_HISTOGRAM : base::HISTOGRAM);

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »