Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4192)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index 1b7a2642b219dac0582a749e85866394071e2cd6..9acec23bd6f887de811d8c039a141d7269b11ecf 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -124,7 +124,7 @@ class ExtensionDevToolsClientHost : public content::DevToolsAgentHostClient,
PendingRequests;
PendingRequests pending_requests_;
infobars::InfoBar* infobar_;
- OnDetach::Reason detach_reason_;
+ api::debugger::DetachReason detach_reason_;
// Listen to extension unloaded notification.
ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
@@ -311,7 +311,7 @@ ExtensionDevToolsClientHost::ExtensionDevToolsClientHost(
extension_id_(extension_id),
last_request_id_(0),
infobar_(infobar),
- detach_reason_(OnDetach::REASON_TARGET_CLOSED),
+ detach_reason_(api::debugger::DETACH_REASON_TARGET_CLOSED),
extension_registry_observer_(this) {
CopyDebuggee(&debuggee_, debuggee);
@@ -361,7 +361,7 @@ void ExtensionDevToolsClientHost::AgentHostClosed(
DevToolsAgentHost* agent_host, bool replaced_with_another_client) {
DCHECK(agent_host == agent_host_.get());
if (replaced_with_another_client)
- detach_reason_ = OnDetach::REASON_REPLACED_WITH_DEVTOOLS;
+ detach_reason_ = api::debugger::DETACH_REASON_REPLACED_WITH_DEVTOOLS;
SendDetachedEvent();
delete this;
}
@@ -391,7 +391,7 @@ void ExtensionDevToolsClientHost::SendMessageToBackend(
}
void ExtensionDevToolsClientHost::MarkAsDismissed() {
- detach_reason_ = OnDetach::REASON_CANCELED_BY_USER;
+ detach_reason_ = api::debugger::DETACH_REASON_CANCELED_BY_USER;
}
void ExtensionDevToolsClientHost::SendDetachedEvent() {

Powered by Google App Engine
This is Rietveld 408576698