chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

index b4837899b85f235bad84e584ef2fe43302844da0..dfdf3cb1fd9a96c6aac265c7c59133f6b7840ea4 100644

--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

@@ -34,7 +34,8 @@ TEST_F(ActivityLogApiUnitTest, ConvertChromeApiAction) {

kApiCall));

action->set_args(args.Pass());

scoped_ptr<ExtensionActivity> result = action->ConvertToExtensionActivity();

- ASSERT_EQ(ExtensionActivity::ACTIVITY_TYPE_API_CALL, result->activity_type);

+ ASSERT_EQ(api::activity_log_private::EXTENSION_ACTIVITY_TYPE_API_CALL,

+ result->activity_type);

ASSERT_EQ(kExtensionId, *(result->extension_id.get()));

ASSERT_EQ(kApiCall, *(result->api_call.get()));

ASSERT_EQ(kArgs, *(result->args.get()));

@@ -64,7 +65,8 @@ TEST_F(ActivityLogApiUnitTest, ConvertDomAction) {

ASSERT_EQ(kApiCall, *(result->api_call.get()));

ASSERT_EQ(kArgs, *(result->args.get()));

scoped_ptr<ExtensionActivity::Other> other(result->other.Pass());

- ASSERT_EQ(ExtensionActivity::Other::DOM_VERB_INSERTED, other->dom_verb);

+ ASSERT_EQ(api::activity_log_private::EXTENSION_ACTIVITY_DOM_VERB_INSERTED,

+ other->dom_verb);

ASSERT_TRUE(other->prerender.get());

ASSERT_EQ("12345", *(result->activity_id.get()));

}