[Extensions API] Remove inline enums

extensions/renderer/resources/binding.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var Event = require('event_bindings').Event;
 var forEach = require('utils').forEach;
 var GetAvailability = requireNative('v8_context').GetAvailability;
 var exceptionHandler = require('uncaught_exception_handler');
 var lastError = require('lastError');
 var logActivity = requireNative('activityLogger');
@@ skipping 271 matching lines @@
 
         // Add types to global schemaValidator; the types we depend on from
         // other namespaces will be added as needed.
         schemaUtils.schemaValidator.addTypes(t);
 
         // Generate symbols for enums.
         var enumValues = t['enum'];
         if (enumValues) {
           // Type IDs are qualified with the namespace during compilation,
           // unfortunately, so remove it here.
-          logging.DCHECK(
-              t.id.substr(0, schema.namespace.length) == schema.namespace);
+          logging.DCHECK($String.substr(t.id, 0, schema.namespace.length) ==
+                             schema.namespace);
           // Note: + 1 because it ends in a '.', e.g., 'fooApi.Type'.
-          var id = t.id.substr(schema.namespace.length + 1);
+          var id = $String.substr(t.id, schema.namespace.length + 1);
           mod[id] = {};
           $Array.forEach(enumValues, function(enumValue) {
             // Note: enums can be declared either as a list of strings
             // ['foo', 'bar'] or as a list of objects
             // [{'name': 'foo'}, {'name': 'bar'}].
-            enumValue =
-                enumValue.hasOwnProperty('name') ? enumValue.name : enumValue;
+            enumValue = $Object.hasOwnProperty(enumValue, 'name') ?
+                enumValue.name : enumValue;
             if (enumValue)  // Avoid setting any empty enums.
               mod[id][enumValue] = enumValue;
           });
         }
       }, this);
     }
 
     // TODO(cduvall): Take out when all APIs have been converted to features.
     // Returns whether access to the content of a schema should be denied,
     // based on the presence of "unprivileged" and whether this is an
@@ skipping 192 matching lines @@
                     availability.message);
       return;
     }
 
     this.runHooks_(mod);
     return mod;
   }
 };
 
 exports.Binding = Binding;