Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1055633004: Revert "Re-factor VisibleSelectionTest for adding tests for composed tree version" (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
tkent, yosin
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Re-factor VisibleSelectionTest for adding tests for composed tree version" This reverts commit 52847e6579f5703d41a96349992b79f1ae258b98. Reason for revert: Breaks Android Builder (dbg) compilation, http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20(dbg)/builds/43678 (and Oilpan compilation.) Original issue's description: > Re-factor VisibleSelectionTest for adding tests for composed tree version > > This patch changes |VisibleSelectionTest| for adding tests for composed tree > version easier with introducing shadow tree related tests. > > This patch also introduces |Node| and |Position| for ease of writing and > debugging gTest. > > This patch is result of collaboration work with hajimehoshi@chromium.org > for selection of web components. After this patch, we are going to implement > another strategies for the composed tree. We've already > prepared that at http://crrev.com/1009603011. > > BUG=275851 > TEST=n/a; No behavior changes. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194195 TBR=yosin,tkent NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=275851 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -231 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 8 chunks +50 lines, -117 lines 0 comments Download
D Source/core/testing/CoreTestHelpers.h View 1 chunk +0 lines, -22 lines 0 comments Download
D Source/core/testing/CoreTestHelpers.cpp View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sof
5 years, 8 months ago (2015-04-22 07:02:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055633004/1
5 years, 8 months ago (2015-04-22 07:02:54 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 07:03:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194197

Powered by Google App Engine
This is Rietveld 408576698