Issue 105563004: Pass -Goutput_dir=. to the make generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105563004: Pass -Goutput_dir=. to the make generator. (Closed)

Created:
7 years ago by Nico

Modified:
7 years ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Pass -Goutput_dir=. to the make generator. This makes it possible to remove the builddir_name hack added in r238632. BUG=315004

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	build/gyp_v8	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Nico

7 years ago (2013-12-04 23:15:12 UTC) #1

With this, the global makefile wouldn't have to set `builddir` in the `buildbot`
target either (but that target isn't used any more).

If this lgty, you probably have to land this yourself since this is probably off
the wrong branch (?)

Expand Messages | Collapse Messages