Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1055573003: Report unused elements in GenerateHintsTask. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/test/src/task/dart_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 40b4b4aff19f64f6d38b0975a7d31add56c08260..8d5a21813e01a8849726aef49c5256ee40254627 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -1736,6 +1736,11 @@ class GenerateHintsTask extends SourceBasedAnalysisTask {
static const String UNIT_INPUT = 'UNIT_INPUT';
/**
+ * The name of a list of [USED_ELEMENTS] for each library unit input.
+ */
+ static const String USED_ELEMENTS_INPUT = 'USED_ELEMENTS_INPUT';
+
+ /**
* The task descriptor describing this kind of task.
*/
static final TaskDescriptor DESCRIPTOR = new TaskDescriptor(
@@ -1756,17 +1761,23 @@ class GenerateHintsTask extends SourceBasedAnalysisTask {
// Prepare inputs.
//
CompilationUnit unit = getRequiredInput(UNIT_INPUT);
+ List<UsedElements> usedElementsList = getRequiredInput(USED_ELEMENTS_INPUT);
CompilationUnitElement unitElement = unit.element;
LibraryElement libraryElement = unitElement.library;
//
- // Use the HintGenerator to generate errors.
+ // Generate errors.
//
// TODO(scheglov) move collecting used imports into a separate task
// unit.accept(_importsVerifier);
// Dead code analysis.
unit.accept(new DeadCodeVerifier(errorReporter));
- // TODO(scheglov) move collecting used elements into a separate task
-// unit.accept(_usedElementsVisitor);
+ // Unused elements.
+ {
+ UsedElements usedElements = new UsedElements.merge(usedElementsList);
+ UnusedElementsVerifier visitor =
+ new UnusedElementsVerifier(errorListener, usedElements);
+ unitElement.accept(visitor);
+ }
// Dart2js analysis.
if (context.analysisOptions.dart2jsHint) {
unit.accept(new Dart2JSVerifier(errorReporter));
@@ -1791,7 +1802,14 @@ class GenerateHintsTask extends SourceBasedAnalysisTask {
* given [target].
*/
static Map<String, TaskInput> buildInputs(LibraryUnitTarget target) {
- return <String, TaskInput>{UNIT_INPUT: RESOLVED_UNIT.of(target)};
+ Source libSource = target.library;
+ return <String, TaskInput>{
+ UNIT_INPUT: RESOLVED_UNIT.of(target),
+ USED_ELEMENTS_INPUT: UNITS.of(libSource).toList((unit) {
+ LibraryUnitTarget target = new LibraryUnitTarget(libSource, unit);
+ return USED_ELEMENTS.of(target);
+ })
+ };
}
/**
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/test/src/task/dart_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698