Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1055543004: Move Cache Storage API implementation to modules/cachestorage (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 8 months ago
Reviewers:
dmurph
CC:
abarth-chromium, blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Cache Storage API implementation to modules/cachestorage Since it's no longer limited to Service Worker context, give it a module of its very own. Add jkarlin to OWNERS BUG=439389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193152

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1999 lines) Patch
A + Source/modules/cachestorage/Cache.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/cachestorage/Cache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/cachestorage/Cache.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/cachestorage/CacheQueryOptions.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/cachestorage/CacheStorage.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/cachestorage/CacheStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/cachestorage/CacheStorage.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/cachestorage/CacheTest.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
A + Source/modules/cachestorage/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/modules/cachestorage/GlobalCacheStorage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/cachestorage/GlobalCacheStorage.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/cachestorage/InspectorCacheStorageAgent.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 4 chunks +8 lines, -9 lines 0 comments Download
A + Source/modules/cachestorage/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/modules/cachestorage/WindowCacheStorage.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/cachestorage/WorkerCacheStorage.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/modules/modules.gypi View 12 chunks +16 lines, -16 lines 0 comments Download
D Source/modules/serviceworkers/Cache.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/modules/serviceworkers/Cache.cpp View 1 1 chunk +0 lines, -414 lines 0 comments Download
D Source/modules/serviceworkers/Cache.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D Source/modules/serviceworkers/CacheQueryOptions.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D Source/modules/serviceworkers/CacheStorage.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/modules/serviceworkers/CacheStorage.cpp View 1 chunk +0 lines, -281 lines 0 comments Download
D Source/modules/serviceworkers/CacheStorage.idl View 1 chunk +0 lines, -17 lines 0 comments Download
D Source/modules/serviceworkers/CacheTest.cpp View 1 chunk +0 lines, -559 lines 0 comments Download
M Source/modules/serviceworkers/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D Source/modules/serviceworkers/GlobalCacheStorage.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
D Source/modules/serviceworkers/GlobalCacheStorage.cpp View 1 1 chunk +0 lines, -84 lines 0 comments Download
D Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.h View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/modules/serviceworkers/InspectorServiceWorkerCacheAgent.cpp View 1 chunk +0 lines, -341 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
D Source/modules/serviceworkers/WindowCacheStorage.idl View 1 1 chunk +0 lines, -11 lines 0 comments Download
D Source/modules/serviceworkers/WorkerCacheStorage.idl View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jsbell
This is dependent on https://codereview.chromium.org/1057443002/ or another fix for http://crbug.com/472273
5 years, 8 months ago (2015-04-01 18:56:10 UTC) #1
jsbell
dmurph: Should I wait on the devtools changes or go ahead and get this landed?
5 years, 8 months ago (2015-04-03 19:34:27 UTC) #3
dmurph
On 2015/04/03 at 19:34:27, jsbell wrote: > dmurph: Should I wait on the devtools changes ...
5 years, 8 months ago (2015-04-03 20:37:50 UTC) #4
dmurph
lgtm
5 years, 8 months ago (2015-04-03 21:16:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055543004/20001
5 years, 8 months ago (2015-04-03 21:30:00 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:32:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193152

Powered by Google App Engine
This is Rietveld 408576698