public/platform/WebMediaPlayerClient.h - Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebMediaPlayerClient.h

Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebMediaPlayerClient.h

diff --git a/public/platform/WebMediaPlayerClient.h b/public/platform/WebMediaPlayerClient.h

index 2a1fdab642cc1baa83082238063450a769fa42ae..a242e27c86704401753ff5ea9aac651c4b6ea1bb 100644

--- a/public/platform/WebMediaPlayerClient.h

+++ b/public/platform/WebMediaPlayerClient.h

@@ -31,8 +31,8 @@

#ifndef WebMediaPlayerClient_h

#define WebMediaPlayerClient_h

+#include "WebCommon.h"

#include "WebMediaPlayer.h"

-#include "WebMediaPlayerEncryptedMediaClient.h"

namespace blink {

@@ -40,10 +40,7 @@ class WebInbandTextTrack;

class WebLayer;

class WebMediaSource;

-// TODO(srirama): Remove this inheritance when we get rid of the MediaPlayer

-// and MediaPlayerClient interfaces by having HTMLMediaElement implement

-// WebMediaPlayerClient interface. See crbug.com/350571.

-class WebMediaPlayerClient : public WebMediaPlayerEncryptedMediaClient {

+class BLINK_PLATFORM_EXPORT WebMediaPlayerClient {

public:

enum VideoTrackKind {

VideoTrackKindNone,

« no previous file with comments | « Source/web/web.gypi ('k') | public/platform/WebMediaPlayerEncryptedMediaClient.h » ('j') | no next file with comments »