Source/core/html/HTMLVideoElement.h - Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLVideoElement.h

Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/HTMLVideoElement.cpp » ('j') | Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLVideoElement.h

diff --git a/Source/core/html/HTMLVideoElement.h b/Source/core/html/HTMLVideoElement.h

index 0c6d80d80df99d4968129c4232e28a92cfdfa2ab..d8ef5677a3ade40b6dbb9224da0887db536140d0 100644

--- a/Source/core/html/HTMLVideoElement.h

+++ b/Source/core/html/HTMLVideoElement.h

@@ -71,12 +71,10 @@ public:

bool shouldDisplayPosterImage() const { return displayMode() == Poster; }

- KURL posterImageURL() const;

bool hasAvailableVideoFrame() const;

- // FIXME: Remove this when WebMediaPlayerClientImpl::loadInternal does not depend on it.

- virtual KURL mediaPlayerPosterURL() override;

+ // FIXME: Remove this when HTMLMediaElement::prepareAndLoadMediaPlayer does not depend on it.

philipj_slow 2015/07/06 11:07:10 I guess remove this FIXME as well, don't think it'

Srirama 2015/07/09 15:19:37 Done.

+ virtual KURL posterImageURL() const override;

// CanvasImageSource implementation

virtual PassRefPtr<Image> getSourceImageForCanvas(SourceImageMode, SourceImageStatus*) const override;