Source/web/WebKit.cpp - Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebKit.cpp

Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebKit.cpp

diff --git a/Source/web/WebKit.cpp b/Source/web/WebKit.cpp

index 6b1bc9394ebc90a076029c3235be48e270bc17f0..e4f45cce6d202651bd0758d9ec58335a58f45310 100644

--- a/Source/web/WebKit.cpp

+++ b/Source/web/WebKit.cpp

@@ -47,7 +47,6 @@

#include "platform/Logging.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/graphics/ImageDecodingStore.h"

-#include "platform/graphics/media/MediaPlayer.h"

#include "platform/heap/Heap.h"

#include "platform/heap/glue/MessageLoopInterruptor.h"

#include "platform/heap/glue/PendingGCRunner.h"

@@ -55,7 +54,6 @@

#include "public/platform/WebPrerenderingSupport.h"

#include "public/platform/WebThread.h"

#include "web/IndexedDBClientImpl.h"

-#include "web/WebMediaPlayerClientImpl.h"

#include "wtf/Assertions.h"

#include "wtf/CryptographicallyRandomNumber.h"

#include "wtf/MainThread.h"

@@ -191,8 +189,6 @@ void initializeWithoutV8(Platform* platform)

initializer.init();

setIndexedDBClientCreateFunction(IndexedDBClientImpl::create);

- MediaPlayer::setMediaEngineCreateFunction(WebMediaPlayerClientImpl::create);

}

void shutdown()

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/web/FrameLoaderClientImpl.cpp ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »