Source/web/FrameLoaderClientImpl.h - Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index c1789ed9cf7b26444f2a943dc1d9c1c0d2c749d4..9aaff0ffc2183a3065e2960191a09710892c73cd 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -132,6 +132,7 @@ public:

const KURL& /* base_url */,

const Vector<WTF::String>& paramNames,

const Vector<WTF::String>& paramValues) override;

+ virtual PassOwnPtr<WebMediaPlayer> createWebMediaPlayer(HTMLMediaElement*, const WebURL&) override;

virtual ObjectContentType objectContentType(

const KURL&, const WTF::String& mimeType, bool shouldPreferPlugInsForImages) override;

virtual void didChangeScrollOffset() override;

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/web/AssertMatchingEnums.cpp ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »