Source/modules/mediasource/MediaSource.cpp - Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediasource/MediaSource.cpp

Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLMediaElement.cpp ('K') | « Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp ('k') | Source/modules/webaudio/MediaElementAudioSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediasource/MediaSource.cpp

diff --git a/Source/modules/mediasource/MediaSource.cpp b/Source/modules/mediasource/MediaSource.cpp

index 3cd3288b0b4b006f29a1aebe7bda79158ddfee71..d9a242a0c688a02c6f70b99ea1d84f586638198a 100644

--- a/Source/modules/mediasource/MediaSource.cpp

+++ b/Source/modules/mediasource/MediaSource.cpp

@@ -442,7 +442,7 @@ void MediaSource::durationChangeAlgorithm(double newDuration)

// engine gets added that doesn't support this, then we'll need to add logic to handle the substeps.

// 6. Update the media controller duration to new duration and run the HTMLMediaElement duration change algorithm.

- m_attachedElement->durationChanged(newDuration, requestSeek);

+ m_attachedElement->mediaPlayerDurationChanged(newDuration, requestSeek);

}

void MediaSource::setReadyState(const AtomicString& state)