Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: public/web/WebFrameClient.h

Issue 1055503002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added new path for createMediaPlayer Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index 80281d37ceb1483a4dd388906a833e684f26bc97..f04355a1aba92339a5158a263c386c95a262010b 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -71,6 +71,7 @@ class WebFormElement;
class WebGeolocationClient;
class WebMediaPlayer;
class WebMediaPlayerClient;
+class WebMediaPlayerEncryptedMediaClient;
class WebMIDIClient;
class WebNotificationPermissionCallback;
class WebPermissionClient;
@@ -107,9 +108,12 @@ public:
// May return null.
virtual WebPlugin* createPlugin(WebLocalFrame*, const WebPluginParams&) { return 0; }
+ // TODO(srirama): Remove this method once blink updated.
+ virtual WebMediaPlayer* createMediaPlayer(blink::WebLocalFrame*, const blink::WebURL&, blink::WebMediaPlayerClient*, blink::WebContentDecryptionModule*) { return 0; }
ddorwin 2015/05/26 21:33:41 blink:: is unnecessary
Srirama 2015/05/27 17:15:47 Acknowledged.
+
// May return null.
// WebContentDecryptionModule* may be null if one has not yet been set.
- virtual WebMediaPlayer* createMediaPlayer(WebLocalFrame*, const WebURL&, WebMediaPlayerClient*, WebContentDecryptionModule*) { return 0; }
+ virtual WebMediaPlayer* createMediaPlayer(WebLocalFrame*, const WebURL&, WebMediaPlayerClient*, WebMediaPlayerEncryptedMediaClient*, WebContentDecryptionModule*) { return 0; }
// May return null.
virtual WebApplicationCacheHost* createApplicationCacheHost(WebLocalFrame*, WebApplicationCacheHostClient*) { return 0; }

Powered by Google App Engine
This is Rietveld 408576698