Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1055473003: views: Remove early out for empty clip. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Remove early out for empty clip. View::Paint will early out if the view is not inside the invalidation rect passed down from the compositor via the PaintContext. Since View::Paint was first written it had an early out after clipping the canvas to the view's bounds, which was meant to do the same thing. The canvas was clipped to the compositor's invalidation, and if the the View did not intersect the invalidation, the resulting clip would be empty. Now this early out is redundant, and will become extra useless when each View creates its own canvas to record itself into. So remove it. R=sadrul, sky BUG=466426 Committed: https://crrev.com/471feef61b5e73fdf8be7ba73d00326572af770e Cr-Commit-Position: refs/heads/master@{#323705}

Patch Set 1 #

Patch Set 2 : viewclipearlyout: comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M ui/views/view.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 8 months ago (2015-04-02 22:20:23 UTC) #1
sky
LGTM
5 years, 8 months ago (2015-04-02 23:34:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055473003/20001
5 years, 8 months ago (2015-04-03 00:55:12 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 08:35:29 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:36:05 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/471feef61b5e73fdf8be7ba73d00326572af770e
Cr-Commit-Position: refs/heads/master@{#323705}

Powered by Google App Engine
This is Rietveld 408576698