Issue 1055463004: Replace ChildProcess/AppChildProcess with a simple ChildMain().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055463004: Replace ChildProcess/AppChildProcess with a simple ChildMain(). (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@simplify_child_6-x-simplify_child_5

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Replace ChildProcess/AppChildProcess with a simple ChildMain(). (Mostly, app_child_process.cc ends up being renamed to child_main.cc.) R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1e23c674c51ec87c351dad02efea476fead2d862

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -456 lines)			Patch
M	shell/BUILD.gn	View	1 chunk	+2 lines, -4 lines	0 comments	Download
D	shell/app_child_process.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	shell/app_child_process.cc	View	1 chunk	+0 lines, -304 lines	0 comments	Download
A	shell/child_main.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A +	shell/child_main.cc	View	4 chunks	+15 lines, -11 lines	0 comments	Download
D	shell/child_process.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	shell/child_process.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	shell/child_process_host_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/desktop/main.cc	View	3 chunks	+8 lines, -9 lines	0 comments	Download
M	shell/shell_test_main.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

5 years, 8 months ago (2015-04-01 21:46:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1e23c674c51ec87c351dad02efea476fead2d862 (presubmit successful).