Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1055463002: Add note to ContentViewCore.destroy (Closed)

Created:
5 years, 8 months ago by boliu
Modified:
5 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add note to ContentViewCore.destroy To warn about potential leaks in Android WebView. BUG=469803 Committed: https://crrev.com/4242790a39d4b37ea27995e43189983ad469542b Cr-Commit-Position: refs/heads/master@{#323409}

Patch Set 1 #

Total comments: 2

Patch Set 2 : javadoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
boliu
as promised!
5 years, 8 months ago (2015-04-01 15:54:10 UTC) #2
Ted C
lgtm https://codereview.chromium.org/1055463002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/1055463002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1014 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1014: // Note destroy() is not guranteed to be ...
5 years, 8 months ago (2015-04-02 00:20:38 UTC) #3
boliu
https://codereview.chromium.org/1055463002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/1055463002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1014 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1014: // Note destroy() is not guranteed to be called ...
5 years, 8 months ago (2015-04-02 00:35:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055463002/20001
5 years, 8 months ago (2015-04-02 00:36:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 02:28:42 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:21:48 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4242790a39d4b37ea27995e43189983ad469542b
Cr-Commit-Position: refs/heads/master@{#323409}

Powered by Google App Engine
This is Rietveld 408576698