Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: extensions/browser/null_app_sorting.cc

Issue 1055453007: Added CHECKs for null pointers in ChromeAppSorting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added CHECK(this) just to make sure that ExtensionPrefs is non-null. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/null_app_sorting.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/null_app_sorting.h" 5 #include "extensions/browser/null_app_sorting.h"
6 6
7 #include "sync/api/string_ordinal.h" 7 #include "sync/api/string_ordinal.h"
8 8
9 namespace { 9 namespace {
10 10
11 // Ordinals for a single app on a single page. 11 // Ordinals for a single app on a single page.
12 const char kFirstApp[] = "a"; 12 const char kFirstApp[] = "a";
13 const char kNextApp[] = "b"; 13 const char kNextApp[] = "b";
14 const char kFirstPage[] = "a"; 14 const char kFirstPage[] = "a";
15 15
16 } // namespace 16 } // namespace
17 17
18 namespace extensions { 18 namespace extensions {
19 19
20 NullAppSorting::NullAppSorting() { 20 NullAppSorting::NullAppSorting() {
21 } 21 }
22 22
23 NullAppSorting::~NullAppSorting() { 23 NullAppSorting::~NullAppSorting() {
24 } 24 }
25 25
26 void NullAppSorting::SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) { 26 void NullAppSorting::SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) {
27 } 27 }
28 28
29 void NullAppSorting::CheckExtensionScopedPrefs() const {
30 }
31
29 void NullAppSorting::SetExtensionSyncService( 32 void NullAppSorting::SetExtensionSyncService(
30 ExtensionSyncService* extension_sync_service) { 33 ExtensionSyncService* extension_sync_service) {
31 } 34 }
32 35
33 void NullAppSorting::Initialize(const ExtensionIdList& extension_ids) { 36 void NullAppSorting::Initialize(const ExtensionIdList& extension_ids) {
34 } 37 }
35 38
36 void NullAppSorting::FixNTPOrdinalCollisions() { 39 void NullAppSorting::FixNTPOrdinalCollisions() {
37 } 40 }
38 41
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 syncer::StringOrdinal NullAppSorting::PageIntegerAsStringOrdinal( 99 syncer::StringOrdinal NullAppSorting::PageIntegerAsStringOrdinal(
97 size_t page_index) { 100 size_t page_index) {
98 return syncer::StringOrdinal(kFirstPage); 101 return syncer::StringOrdinal(kFirstPage);
99 } 102 }
100 103
101 void NullAppSorting::SetExtensionVisible(const std::string& extension_id, 104 void NullAppSorting::SetExtensionVisible(const std::string& extension_id,
102 bool visible) { 105 bool visible) {
103 } 106 }
104 107
105 } // namespace extensions 108 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/null_app_sorting.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698