Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/extensions/chrome_app_sorting.h

Issue 1055453007: Added CHECKs for null pointers in ChromeAppSorting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added CHECK(this) just to make sure that ExtensionPrefs is non-null. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 11 matching lines...) Expand all
22 22
23 class ExtensionScopedPrefs; 23 class ExtensionScopedPrefs;
24 24
25 class ChromeAppSorting : public AppSorting { 25 class ChromeAppSorting : public AppSorting {
26 public: 26 public:
27 ChromeAppSorting(); 27 ChromeAppSorting();
28 ~ChromeAppSorting() override; 28 ~ChromeAppSorting() override;
29 29
30 // AppSorting implementation: 30 // AppSorting implementation:
31 void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override; 31 void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) override;
32 void CheckExtensionScopedPrefs() const override;
32 void SetExtensionSyncService( 33 void SetExtensionSyncService(
33 ExtensionSyncService* extension_sync_service) override; 34 ExtensionSyncService* extension_sync_service) override;
34 void Initialize(const extensions::ExtensionIdList& extension_ids) override; 35 void Initialize(const extensions::ExtensionIdList& extension_ids) override;
35 void FixNTPOrdinalCollisions() override; 36 void FixNTPOrdinalCollisions() override;
36 void EnsureValidOrdinals( 37 void EnsureValidOrdinals(
37 const std::string& extension_id, 38 const std::string& extension_id,
38 const syncer::StringOrdinal& suggested_page) override; 39 const syncer::StringOrdinal& suggested_page) override;
39 void OnExtensionMoved(const std::string& moved_extension_id, 40 void OnExtensionMoved(const std::string& moved_extension_id,
40 const std::string& predecessor_extension_id, 41 const std::string& predecessor_extension_id,
41 const std::string& successor_extension_id) override; 42 const std::string& successor_extension_id) override;
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 176
176 // The set of extensions that don't appear in the new tab page. 177 // The set of extensions that don't appear in the new tab page.
177 std::set<std::string> ntp_hidden_extensions_; 178 std::set<std::string> ntp_hidden_extensions_;
178 179
179 DISALLOW_COPY_AND_ASSIGN(ChromeAppSorting); 180 DISALLOW_COPY_AND_ASSIGN(ChromeAppSorting);
180 }; 181 };
181 182
182 } // namespace extensions 183 } // namespace extensions
183 184
184 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_ 185 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_APP_SORTING_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698