Issue 105543004: Add bindings tests coverage for reflected attributes with a SVG animated type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105543004: Add bindings tests coverage for reflected attributes with a SVG animated type (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add bindings tests coverage for reflected attributes with a SVG animated type Add bindings tests coverage for reflected attributes with a SVG animated type. We need to make sure getAttribute is used instead of fastGetAttribute. R=haraken BUG=328619 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163909

Patch Set 1 #

Total comments: 1

Patch Set 2 : Group new attribute with other reflected attributes #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	Source/bindings/tests/idls/TestObject.idl	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/bindings/tests/results/V8TestObject.cpp	View	1	3 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/105543004/diff/1/Source/bindings/tests/results/V8TestObject.cpp File Source/bindings/tests/results/V8TestObject.cpp (right): https://codereview.chromium.org/105543004/diff/1/Source/bindings/tests/results/V8TestObject.cpp#newcode2895 Source/bindings/tests/results/V8TestObject.cpp:2895: v8SetReturnValueFast(info, imp->getAttribute(HTMLNames::animatedreflectedattributeAttr), imp); Calling getAttribute(), as expected.

7 years ago (2013-12-14 04:18:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/105543004/20001

7 years ago (2013-12-14 04:24:40 UTC) #4

Message was sent while issue was closed.

Change committed as 163909

Expand Messages | Collapse Messages