Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1055423002: Add UMA to understand the typical total size of ServiceWorker script [2/2 chromium] (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
Reviewers:
Kunihiko Sakamoto, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA to understand the typical total size of ServiceWorker script [2/2 chromium] This cl introduces three UMAs. - ServiceWorker.ScriptCount - ServiceWorker.ScriptTotalSize - ServiceWorker.ScriptCachedMetadataTotalSize 1/2 blink: https://codereview.chromium.org/1059193002/ 2/2 chromium: This cl. BUG=408451 Committed: https://crrev.com/1085f573094f9d09978915bef54a5283c20782b2 Cr-Commit-Position: refs/heads/master@{#324180}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
horo
ksakamoto@ Could you please review this?
5 years, 8 months ago (2015-04-03 08:37:42 UTC) #3
Kunihiko Sakamoto
lgtm
5 years, 8 months ago (2015-04-03 09:10:08 UTC) #4
horo
jwd@ Could you please review this?
5 years, 8 months ago (2015-04-03 09:13:56 UTC) #6
jwd
lgtm
5 years, 8 months ago (2015-04-07 15:33:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055423002/20001
5 years, 8 months ago (2015-04-08 01:09:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-08 02:51:24 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 02:52:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1085f573094f9d09978915bef54a5283c20782b2
Cr-Commit-Position: refs/heads/master@{#324180}

Powered by Google App Engine
This is Rietveld 408576698