Issue 1055413003: Introduce common superclass to fix ClassElement.node (issue 23120)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055413003: Introduce common superclass to fix ClassElement.node (issue 23120) (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson

Modified:
5 years, 8 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Introduce common superclass to fix ClassElement.node (issue 23120) R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44971

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -111 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View	27 chunks	+55 lines, -108 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

lgtm, however here's an alternative you may want to consider: Exclude FunctionDeclaration from the newly ...

5 years, 8 months ago (2015-04-07 20:21:08 UTC) #3

Brian Wilkerson

5 years, 8 months ago (2015-04-08 15:58:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44971 (presubmit successful).