content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc - Issue 1055403010: content: Add GpuMemoryBuffer MemoryDumpProvider implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

Issue 1055403010: content: Add GpuMemoryBuffer MemoryDumpProvider implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: save register of dump provider to follow up patch Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_memory_buffer_impl.h ('K') | « content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc » ('j') | content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

index 0fa6e814c896c45177791ab0a6c4c33cb9cfec77..b1611b38e2ac90f42a95519eb77c00e457451284 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

@@ -82,12 +82,13 @@ bool GpuMemoryBufferImplSurfaceTexture::Map(void** data) {

return false;

}

- size_t stride_in_bytes = 0;

- if (!StrideInBytes(buffer.stride, format_, 0, &stride_in_bytes))

- return false;

DCHECK_LE(size_.width(), buffer.stride);

- stride_ = stride_in_bytes;

+ size_t row_size_in_bytes = 0;

+ bool valid_row_size =

+ RowSizeInBytes(buffer.stride, format_, 0, &row_size_in_bytes);

+ DCHECK(valid_row_size);

+ stride_ = row_size_in_bytes;

mapped_ = true;

*data = buffer.bits;

return true;