Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1055403004: Fix cast from video player by using DriveApiUrlGenerator to generate URL (Closed)

Created:
5 years, 8 months ago by yoshiki
Modified:
5 years, 8 months ago
Reviewers:
mtomasz, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cast from video player by using DriveApiUrlGenerator to generate URL This patch fixes the regression which is caused by the following CL. https://chromium.googlesource.com/chromium/src/+/3315eb5fe7bcb9300995dae3326de2d2c5f3c44a Since the Styx URLs are updated in that CL, we need to use DriveApiUrlGenerator::GenerateDownloadFileURL to create a download URL to pass a cast device. BUG=477733 TEST=can cast a video Committed: https://crrev.com/0dc4cf80cfd2d8976b66f7a9ff79c290c81897e9 Cr-Commit-Position: refs/heads/master@{#326999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yoshiki
@mtomasz: PTAL. Thanks.
5 years, 8 months ago (2015-04-24 18:10:07 UTC) #2
yoshiki
@hirono-san, PTAL at the patch on behalf of Tomasz?
5 years, 8 months ago (2015-04-27 04:17:32 UTC) #4
hirono
lgtm!
5 years, 8 months ago (2015-04-27 04:20:37 UTC) #5
yoshiki
Thank you for quick review!
5 years, 8 months ago (2015-04-27 04:21:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055403004/1
5 years, 8 months ago (2015-04-27 04:21:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 04:59:12 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 05:00:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc4cf80cfd2d8976b66f7a9ff79c290c81897e9
Cr-Commit-Position: refs/heads/master@{#326999}

Powered by Google App Engine
This is Rietveld 408576698