Issue 1055403002: Add an Ioctl() message to the File interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055403002: Add an Ioctl() message to the File interface. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
Elliot Glaysher

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add an Ioctl() message to the File interface. We'll need it for "special" "files" (e.g., terminals). R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/399a2f485c2dcf762ba56c10994fcc32d1e12963

Patch Set 1 #

Patch Set 2 : rebased #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
M	examples/terminal/terminal_file_impl.dart	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	mojo/services/files/public/interfaces/file.mojom	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	services/files/file_impl.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	services/files/file_impl.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	services/files/file_impl_unittest.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

sure why not lgtm (you know I was joking when I asked you about whether ...

5 years, 8 months ago (2015-04-03 17:03:28 UTC) #2

Elliot Glaysher

On 2015/04/03 17:03:28, Elliot Glaysher wrote: > sure why not lgtm > > (you know ...

5 years, 8 months ago (2015-04-03 17:03:41 UTC) #3

viettrungluu

On 2015/04/03 17:03:28, Elliot Glaysher wrote: > sure why not lgtm > > (you know ...

5 years, 8 months ago (2015-04-03 17:20:33 UTC) #4

viettrungluu

5 years, 8 months ago (2015-04-03 17:20:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
399a2f485c2dcf762ba56c10994fcc32d1e12963 (presubmit successful).

Expand Messages | Collapse Messages