Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 105533004: Revert 241977 "Add hook for extension to check sync status." (Closed)

Created:
7 years ago by kinuko
Modified:
7 years ago
Reviewers:
Rune Fevang
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241977 "Add hook for extension to check sync status." Suspected to cause use-after-free on ChromeOS/Linux bot. http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%282%29/builds/15076/steps/browser_tests/logs/GetSyncCategoriesWithoutPassphraseSynchronous Might be test-only, but reverting this as u-a-f doesn't sound good > Add hook for extension to check sync status. > > Adds a new function to preferencesPrivate that returns a list of > unencrypted sync categories. Also changes preferencesPrivate to use a > whitelist instead of being restricted to component extensions. > > BUG=326678 > > Review URL: https://codereview.chromium.org/118413003 TBR=rfevang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -296 lines) Patch
D trunk/src/chrome/browser/extensions/api/preferences_private/preferences_private_api.h View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/preferences_private/preferences_private_api.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_function_histogram_value.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/api.gyp View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/api/preferences_private.json View 1 chunk +1 line, -22 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/preferences_private/manifest.json View 1 chunk +0 lines, -9 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/preferences_private/test.js View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
7 years ago (2013-12-20 07:55:44 UTC) #1
kinuko
Committed patchset #1 manually as r242038.
7 years ago (2013-12-20 07:55:58 UTC) #2
kinuko
7 years ago (2013-12-20 09:30:57 UTC) #3
Message was sent while issue was closed.
CrOS ASAN bot has become green after this revert.

Powered by Google App Engine
This is Rietveld 408576698