Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1055323002: Remove the x,y,width,height methods from HTMLImageElement. (Closed)

Created:
5 years, 8 months ago by ojan
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the x,y,width,height methods from HTMLImageElement. They've already been removed from the idl. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7ae9d82bcd411c5906707c82973ccb155bd517cf

Patch Set 1 #

Patch Set 2 : remove attrs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M sky/engine/core/html/HTMLAttributeNames.in View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 3 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 8 months ago (2015-04-03 01:11:38 UTC) #2
ojan
5 years, 8 months ago (2015-04-06 18:39:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7ae9d82bcd411c5906707c82973ccb155bd517cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698