Issue 1055263002: Make custom layout actually work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055263002: Make custom layout actually work. (Closed)

Created:
5 years, 8 months ago by ojan

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make custom layout actually work. -Temporarily add setting override width as well so that we correctly bypass in RenderBox::computeLogicalWidth. -Add setNeedsLayout so that the author code can force layouts (e.g. when the container's width changes). -Have setLayoutManager force a reattach of the element if it's renderer wasn't a custom layout one before. -Remove the laying out of children from RenderCustomLayout::layout. This is the job of the author code. -Add a test case. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8a2b335355783713f5e9a571ef7498a6e998edd9

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -16 lines)			Patch
M	sky/engine/core/dom/Element.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	3 chunks	+23 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Element.idl	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	sky/engine/core/rendering/RenderCustomLayout.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/rendering/RenderCustomLayout.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/tests/layout/custom.sky	View	1 chunk	+85 lines, -0 lines	0 comments	Download
A +	sky/tests/layout/custom-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

5 years, 8 months ago (2015-04-06 19:53:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a2b335355783713f5e9a571ef7498a6e998edd9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages