Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: trunk/src/content/browser/frame_host/render_frame_host_impl.h

Issue 105523006: Revert 241151 "Make RenderFrameHostManager swap RenderFrameHosts..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/frame_host/render_frame_host_impl.h
===================================================================
--- trunk/src/content/browser/frame_host/render_frame_host_impl.h (revision 241158)
+++ trunk/src/content/browser/frame_host/render_frame_host_impl.h (working copy)
@@ -76,13 +76,8 @@
bool is_swapped_out() { return is_swapped_out_; }
- // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
- // refcount that calls Shutdown when it reaches zero. This allows each
- // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
- // we have a RenderViewHost for each RenderFrameHost.
- // TODO(creis): RenderViewHost will eventually go away and be replaced with
- // some form of page context.
- RenderViewHostImpl* render_view_host_;
+ // TODO(nasko): This should be removed and replaced by RenderProcessHost.
+ RenderViewHostImpl* render_view_host_; // Not owned.
RenderFrameHostDelegate* delegate_;

Powered by Google App Engine
This is Rietveld 408576698