Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1055203002: Fix the RenderFrameProxyHost mop-up logic in RenderFrameHostManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review cleanup. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 89eeef69f9d549dc85a644eb8021a57176ce91d2..911a001039c2f4ae10e4c021e727ab6ba3360e74 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -577,10 +577,12 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
void MoveToPendingDeleteHosts(
scoped_ptr<RenderFrameHostImpl> render_frame_host);
- // Shutdown all RenderFrameProxyHosts in a SiteInstance. This is called to
- // shutdown frames when all the frames in a SiteInstance are confirmed to be
- // swapped out.
- void ShutdownRenderFrameProxyHostsInSiteInstance(int32 site_instance_id);
+ // If |render_frame_host| is the last remaining active frame in its
+ // SiteInstance, this will shutdown all the RenderFrameProxyHosts in the site
Charlie Reis 2015/04/03 19:55:09 nit: s/site instance/SiteInstance/
ncarter (slow) 2015/04/03 22:03:33 Done.
+ // instance. This is appropriate if |render_frame_host| is about to be
+ // destroyed.
+ void ShutdownProxiesIfLastActiveFrameInSiteInstance(
+ RenderFrameHostImpl* render_frame_host);
// Helper method to terminate the pending RenderFrameHost. The frame may be
// deleted immediately, or it may be kept around in hopes of later reuse.

Powered by Google App Engine
This is Rietveld 408576698