Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_info.h

Issue 1055183003: Add a data source field for volumes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed tests. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h b/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
index 795577ce3c72814c833b8f8daa8acfe030b7ade1..4f9cf0e33d9bff1360252ba4b02ae223c5e19e8c 100644
--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
@@ -12,6 +12,9 @@
namespace chromeos {
namespace file_system_provider {
+// Source of the file system's contents.
+enum Source { SOURCE_FILE, SOURCE_DEVICE, SOURCE_NETWORK, SOURCE_UNKNOWN };
hirono 2015/04/06 08:36:34 nit: How about putting SOURCE_UNKNOWN at first so
mtomasz 2015/04/06 09:13:48 I'm not really sure. I put the least expected one
hirono 2015/04/06 09:37:33 It's up to you. I don't have strong feeling about
+
// Options for creating the provided file system info.
struct MountOptions {
MountOptions();
@@ -23,6 +26,7 @@ struct MountOptions {
std::string file_system_id;
std::string display_name;
bool writable;
+ Source source;
bool supports_notify_tag;
int opened_files_limit;
};
@@ -42,6 +46,7 @@ class ProvidedFileSystemInfo {
const std::string& file_system_id() const { return file_system_id_; }
const std::string& display_name() const { return display_name_; }
bool writable() const { return writable_; }
+ Source source() const { return source_; }
bool supports_notify_tag() const { return supports_notify_tag_; }
int opened_files_limit() const { return opened_files_limit_; }
const base::FilePath& mount_path() const { return mount_path_; }
@@ -59,6 +64,9 @@ class ProvidedFileSystemInfo {
// Whether the file system is writable or just read-only.
bool writable_;
+ // Source of the file system's contents. By default SOURCE_UNKNOWN.
+ Source source_;
+
// Supports tags for file/directory change notifications.
bool supports_notify_tag_;

Powered by Google App Engine
This is Rietveld 408576698