Add a data source field for volumes.

Add a data source field for volumes.

Especially for FSP, we'd like to know type of a volume, as the way they are
going to be displayed in Files app depends on it. Eg. SOURCE_FILE volumes will
be auto opened once they are mounted. SOURCE_NETWORK file systems will have
a button for configuration.

TEST=unit_tests, browser_tests
BUG=474146
Committed: https://crrev.com/181fd73aa111fff257616435820a6392e309a5e5
Cr-Commit-Position: refs/heads/master@{#324429}

[mtomasz, 2015-04-06 08:12:56]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org

[mtomasz, 2015-04-06 08:13:04]

@hirono: PTAL. Thanks.

[hirono, 2015-04-06 08:36:34]

https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
(right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/provided_file_system_info.h:16:
enum Source { SOURCE_FILE, SOURCE_DEVICE, SOURCE_NETWORK, SOURCE_UNKNOWN };
nit: How about putting SOURCE_UNKNOWN at first so that its value is 0.

https://codereview.chromium.org/1055183003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/file_system_provider.idl:52: // USB device.
nit: please note downloads's source is device.

https://codereview.chromium.org/1055183003/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/file_system_provider/mount/test.js
(right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/file_system_provider/mount/test.js:71:
source: 'NETWORK'
Should it be FILE?

[mtomasz, 2015-04-06 09:13:48]

https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
(right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/provided_file_system_info.h:16:
enum Source { SOURCE_FILE, SOURCE_DEVICE, SOURCE_NETWORK, SOURCE_UNKNOWN };
On 2015/04/06 08:36:34, hirono wrote:
> nit: How about putting SOURCE_UNKNOWN at first so that its value is 0.

I'm not really sure. I put the least expected one at the end. It's also the same
order as in file_system_provider.idl. UNKNOWN should basically not be used. It's
there only for backward compatibility reasons. All new providers should declare
a source. I'm planning to add a warning in custom bindings.

https://codereview.chromium.org/1055183003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/file_system_provider.idl:52: // USB device.
On 2015/04/06 08:36:34, hirono wrote:
> nit: please note downloads's source is device.

Done in file_manager_private.idl.

https://codereview.chromium.org/1055183003/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/file_system_provider/mount/test.js
(right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/file_system_provider/mount/test.js:71:
source: 'NETWORK'
On 2015/04/06 08:36:34, hirono wrote:
> Should it be FILE?

Done.

[hirono, 2015-04-06 09:37:33]

lgtm!

https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
(right):

https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/provided_file_system_info.h:16:
enum Source { SOURCE_FILE, SOURCE_DEVICE, SOURCE_NETWORK, SOURCE_UNKNOWN };
On 2015/04/06 09:13:48, mtomasz wrote:
> On 2015/04/06 08:36:34, hirono wrote:
> > nit: How about putting SOURCE_UNKNOWN at first so that its value is 0.
> 
> I'm not really sure. I put the least expected one at the end. It's also the
same
> order as in file_system_provider.idl. UNKNOWN should basically not be used.
It's
> there only for backward compatibility reasons. All new providers should
declare
> a source. I'm planning to add a warning in custom bindings.

It's up to you. I don't have strong feeling about this and there is no practical
difference. Just thought of other enums which start with NONE or UNKNOWN:
https://code.google.com/p/chromium/codesearch#search/&q=enum%20none&sq=packag...

[mtomasz, 2015-04-06 11:00:40]

On 2015/04/06 09:37:33, hirono wrote:
> lgtm!
> 
>
https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
> (right):
> 
>
https://codereview.chromium.org/1055183003/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/file_system_provider/provided_file_system_info.h:16:
> enum Source { SOURCE_FILE, SOURCE_DEVICE, SOURCE_NETWORK, SOURCE_UNKNOWN };
> On 2015/04/06 09:13:48, mtomasz wrote:
> > On 2015/04/06 08:36:34, hirono wrote:
> > > nit: How about putting SOURCE_UNKNOWN at first so that its value is 0.
> > 
> > I'm not really sure. I put the least expected one at the end. It's also the
> same
> > order as in file_system_provider.idl. UNKNOWN should basically not be used.
> It's
> > there only for backward compatibility reasons. All new providers should
> declare
> > a source. I'm planning to add a warning in custom bindings.
> 
> It's up to you. I don't have strong feeling about this and there is no
practical
> difference. Just thought of other enums which start with NONE or UNKNOWN:
>
https://code.google.com/p/chromium/codesearch#search/&q=enum%20none&sq=packag...

Indeed it's more often. Changed as you suggested. Done.

[mtomasz, 2015-04-06 11:01:57]

mtomasz@chromium.org changed reviewers:
+ benwells@chromium.org

[mtomasz, 2015-04-06 11:02:23]

@benwells: PTAL at chrome/common/extensions/api/file_system_provider.idl. Sorry
for so many CLs, but this is tiny.

[mtomasz, 2015-04-09 07:19:22]

On 2015/04/06 11:02:23, mtomasz wrote:
> @benwells: PTAL at chrome/common/extensions/api/file_system_provider.idl.
Sorry
> for so many CLs, but this is tiny.

@benwells: Friendly ping (IDL only).

[benwells, 2015-04-09 07:32:12]

lgtm

sorry, missed this one.

https://codereview.chromium.org/1055183003/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/1055183003/diff/80001/chrome/common/extension...
chrome/common/extensions/api/file_system_provider.idl:477: // </code> option
must be set apprioprietly.
Nit: Spelling of appropriately.

[mtomasz, 2015-04-09 12:42:36]

https://codereview.chromium.org/1055183003/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/1055183003/diff/80001/chrome/common/extension...
chrome/common/extensions/api/file_system_provider.idl:477: // </code> option
must be set apprioprietly.
On 2015/04/09 07:32:12, benwells wrote:
> Nit: Spelling of appropriately.

Done.

[mtomasz, 2015-04-09 12:42:45]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-04-09 12:42:45]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org,
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1055183003/#ps90001
(title: "Fixed a typo.")

[commit-bot: I haz the power, 2015-04-09 12:43:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055183003/90001

[commit-bot: I haz the power, 2015-04-09 13:56:29]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-04-09 13:57:27]

Patchset 6 (id:??) landed as
https://crrev.com/181fd73aa111fff257616435820a6392e309a5e5
Cr-Commit-Position: refs/heads/master@{#324429}