Issue 1055173006: Revert of Implement Custom Element's class side inheritance

Issue 1055173006: Revert of Implement Custom Element's class side inheritance (Closed)

Created:
5 years, 8 months ago by dominicc (has gone to gerrit)

Modified:
5 years, 8 months ago

Reviewers:
haraken, deepak.s, esprehn

CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Implement Custom Element's class side inheritance (patchset #2 id:20001 of https://codereview.chromium.org/1069953002/) Reason for revert: This caused Issue 478329. Original issue's description: > Implement Custom Element's class side inheritance > > Custom element should set __proto__ internal property of the generated > constructor. __proto__ should be set to base class object. > As class inheritance is supported in DOM elements, it should also be > supported in Custom elements. > > BUG=271466, 443369 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193847 TBR=esprehn@chromium.org,haraken@chromium.org,deepak.s@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=271466, 443369 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194079

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -119 lines)			Patch
D	LayoutTests/fast/dom/custom/class-side-inheritence.html	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	LayoutTests/fast/dom/custom/inherited-prototype.html	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval.html	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval-expected.txt	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	Source/bindings/core/v8/CustomElementConstructorBuilder.cpp	View	1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

dominicc (has gone to gerrit)

Created Revert of Implement Custom Element's class side inheritance

5 years, 8 months ago (2015-04-21 03:56:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055173006/1

5 years, 8 months ago (2015-04-21 03:56:42 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194079

5 years, 8 months ago (2015-04-21 03:57:24 UTC) #3

Message was sent while issue was closed.

LGTM