Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1055153002: android: Check that we do not include the same resource in multiple pak files. (Closed)

Created:
5 years, 8 months ago by sadrul
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Check that we do not include the same resource in multiple pak files. BUG=tbd

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/chrome_android_paks.gypi View 1 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
sadrul
Hi! Does this look like something that may be useful? The change needed for grit ...
5 years, 8 months ago (2015-04-02 20:49:32 UTC) #2
aurimas (slooooooooow)
This looks great! LGTM
5 years, 8 months ago (2015-04-02 20:54:33 UTC) #3
sadrul
5 years, 7 months ago (2015-05-13 18:51:06 UTC) #4
Landed https://codereview.chromium.org/1115033003/ instead for all platforms. So
closing this one.

Powered by Google App Engine
This is Rietveld 408576698