Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: Source/modules/storage/InspectorDOMStorageAgent.cpp

Issue 1055133003: Oilpan: have Storage objects reside on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: trivial cl footprint reduction Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/storage/InspectorDOMStorageAgent.cpp
diff --git a/Source/modules/storage/InspectorDOMStorageAgent.cpp b/Source/modules/storage/InspectorDOMStorageAgent.cpp
index 4d4cc82076a9c1dbce39c22a4a2749f5227e267d..a84859a5d2893cfddf45b4aa98103e7ad91ae0f2 100644
--- a/Source/modules/storage/InspectorDOMStorageAgent.cpp
+++ b/Source/modules/storage/InspectorDOMStorageAgent.cpp
@@ -112,7 +112,7 @@ void InspectorDOMStorageAgent::disable(ErrorString*)
void InspectorDOMStorageAgent::getDOMStorageItems(ErrorString* errorString, const RefPtr<JSONObject>& storageId, RefPtr<TypeBuilder::Array<TypeBuilder::Array<String>>>& items)
{
LocalFrame* frame;
- OwnPtrWillBeRawPtr<StorageArea> storageArea = findStorageArea(errorString, storageId, frame);
+ StorageArea* storageArea = findStorageArea(errorString, storageId, frame);
if (!storageArea)
return;
@@ -144,7 +144,7 @@ static String toErrorString(ExceptionState& exceptionState)
void InspectorDOMStorageAgent::setDOMStorageItem(ErrorString* errorString, const RefPtr<JSONObject>& storageId, const String& key, const String& value)
{
LocalFrame* frame;
- OwnPtrWillBeRawPtr<StorageArea> storageArea = findStorageArea(0, storageId, frame);
+ StorageArea* storageArea = findStorageArea(0, storageId, frame);
if (!storageArea) {
*errorString = "Storage not found";
return;
@@ -158,7 +158,7 @@ void InspectorDOMStorageAgent::setDOMStorageItem(ErrorString* errorString, const
void InspectorDOMStorageAgent::removeDOMStorageItem(ErrorString* errorString, const RefPtr<JSONObject>& storageId, const String& key)
{
LocalFrame* frame;
- OwnPtrWillBeRawPtr<StorageArea> storageArea = findStorageArea(0, storageId, frame);
+ StorageArea* storageArea = findStorageArea(0, storageId, frame);
if (!storageArea) {
*errorString = "Storage not found";
return;
@@ -205,7 +205,7 @@ static LocalFrame* findFrameWithSecurityOrigin(LocalFrame* inspectedFrame, const
return nullptr;
}
-PassOwnPtrWillBeRawPtr<StorageArea> InspectorDOMStorageAgent::findStorageArea(ErrorString* errorString, const RefPtr<JSONObject>& storageId, LocalFrame*& targetFrame)
+StorageArea* InspectorDOMStorageAgent::findStorageArea(ErrorString* errorString, const RefPtr<JSONObject>& storageId, LocalFrame*& targetFrame)
{
String securityOrigin;
bool isLocalStorage = false;
@@ -235,4 +235,3 @@ PassOwnPtrWillBeRawPtr<StorageArea> InspectorDOMStorageAgent::findStorageArea(Er
}
} // namespace blink
-

Powered by Google App Engine
This is Rietveld 408576698