Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1055113004: cc: Aggressively expire retro frames. (Closed)

Created:
5 years, 8 months ago by sunnyps
Modified:
5 years, 7 months ago
Reviewers:
brianderson
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Aggressively expire retro frames. If we're not aggressive about expiring a retro frame (e.g. MISSED frames) then it's possible to enter a high latency mode often. PixelTestOutputSurface is used by the ui compositor in tests and we should not subtract the default estimated parent draw time from the deadline in that case. Doing so will cause MISSED frames to always expire in tests. BUG=469953 Committed: https://crrev.com/7e4f0459fd2d0af0e1b5a6a5069465862afb5bae Cr-Commit-Position: refs/heads/master@{#330669}

Patch Set 1 #

Patch Set 2 : Do not adjust deadline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M cc/scheduler/scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 6 chunks +62 lines, -12 lines 0 comments Download
M cc/test/pixel_test_output_surface.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
sunnyps
PTAL
5 years, 8 months ago (2015-04-16 02:06:59 UTC) #2
brianderson
lgtm
5 years, 8 months ago (2015-04-16 17:39:17 UTC) #3
brianderson
Sunny, I tried this patch with the DisplayScheudler and it improves Browser scheduling a ton ...
5 years, 7 months ago (2015-05-18 20:31:31 UTC) #4
sunnyps
On 2015/05/18 20:31:31, brianderson wrote: > Sunny, I tried this patch with the DisplayScheudler and ...
5 years, 7 months ago (2015-05-18 20:39:01 UTC) #5
brianderson
Yeah. I think this will be a win - let's see what happens.
5 years, 7 months ago (2015-05-18 20:41:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055113004/1
5 years, 7 months ago (2015-05-18 20:47:24 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 00:22:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055113004/1
5 years, 7 months ago (2015-05-19 01:01:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 01:04:42 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bb5a390066a1baf27ec44228fd3ba4173f93cfbf Cr-Commit-Position: refs/heads/master@{#330465}
5 years, 7 months ago (2015-05-19 01:05:23 UTC) #14
Thiemo Nagel
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1135003006/ by tnagel@chromium.org. ...
5 years, 7 months ago (2015-05-19 11:36:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055113004/20001
5 years, 7 months ago (2015-05-20 00:21:00 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 01:44:08 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 01:45:02 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e4f0459fd2d0af0e1b5a6a5069465862afb5bae
Cr-Commit-Position: refs/heads/master@{#330669}

Powered by Google App Engine
This is Rietveld 408576698