SkPMFloat: fewer internal this->isValid() assertions.

SkPMFloat: fewer internal this->isValid() assertions.

  Each of these conversion functions now only asserts is output is valid.
  For SkPMColor -> SkPMFloat, we assert isValid().
  For SkPMFloat -> SkPMColor, we SkPMColorAssert.

 #floats

BUG=skia:
BUG=skia:3592
Committed: https://skia.googlesource.com/skia/+/07342361a3cda94376230b37d9e863052449653c

[reed2, 2015-04-02 18:10:38]

reed@chromium.org changed reviewers:
+ reed@chromium.org

[reed2, 2015-04-02 18:10:39]

The dox could/should says that they assert on the returned pmcolor.

lgtm

[mtklein, 2015-04-02 18:12:10]

On 2015/04/02 18:10:39, reed2 wrote:
> The dox could/should says that they assert on the returned pmcolor.
> 
> lgtm

Done.

[mtklein, 2015-04-02 18:12:13]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-04-02 18:12:13]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@chromium.org
Link to the patchset: https://codereview.chromium.org/1055093002/#ps20001
(title: "doc")

[commit-bot: I haz the power, 2015-04-02 18:12:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055093002/20001

[reed2, 2015-04-02 18:13:59]

reed@chromium.org changed reviewers:
- mtklein@google.com

[reed2, 2015-04-02 18:13:59]

At some point I'd vote to rename get() to something more parallel to trunc(),
making it clear that it rounds.

e.g.
round()
trunc()

or
roundToPMColor()

Also, should clarify what clamped() is doing (round or trunc)?

[mtklein, 2015-04-02 18:21:08]

On 2015/04/02 18:13:59, reed2 wrote:
> At some point I'd vote to rename get() to something more parallel to trunc(),
> making it clear that it rounds.
> 
> e.g.
> round()
> trunc()
> 
> or
> roundToPMColor()
> 
> Also, should clarify what clamped() is doing (round or trunc)?

I agree.  How about trunc(), round(), and roundClamp()?

[commit-bot: I haz the power, 2015-04-02 18:21:16]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/07342361a3cda94376230b37d9e863052449653c