Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 1055083003: Revert of Disable benchmarks failing due to AdbShellCommandFailedError. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable benchmarks failing due to AdbShellCommandFailedError. (patchset #1 id:1 of https://codereview.chromium.org/1069223002/) Reason for revert: Revert since fix has been landed in BUG=474696 BUG=475510 Original issue's description: > Disable benchmarks failing due to AdbShellCommandFailedError. > > BUG=474696 > > Committed: https://crrev.com/9228e12295ebabcd45d0a0d103a35a69db0c6919 > Cr-Commit-Position: refs/heads/master@{#324239} TBR=dtu@chromium.org,aiolos@chromium.org BUG=474696 Committed: https://crrev.com/a3a622d961b41d13c23e59846426077b41948fb7 Cr-Commit-Position: refs/heads/master@{#324529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/benchmarks/power.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nednguyen
Created Revert of Disable benchmarks failing due to AdbShellCommandFailedError.
5 years, 8 months ago (2015-04-09 20:02:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055083003/1
5 years, 8 months ago (2015-04-09 20:04:03 UTC) #3
dtu
lgtm
5 years, 8 months ago (2015-04-09 22:47:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 22:53:57 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 22:55:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3a622d961b41d13c23e59846426077b41948fb7
Cr-Commit-Position: refs/heads/master@{#324529}

Powered by Google App Engine
This is Rietveld 408576698