Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 1055053004: Reland of: [Presentation API] Implement ondefaultsessionstart in PSImpl. (Closed)

Created:
5 years, 8 months ago by imcheng (use chromium acct)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of: [Presentation API] Implement ondefaultsessionstart in PSImpl. To fix PresentationServiceImplTest.DefaultSessionStartReset timeout in Android Tests (dbg). TEST=git cl try + linux_android_dbg_ng ---- Added DefaultSessionStartContext for coordinating sending default session back to PresentationDispatcher. When ListenForDefaultSessionStart is called, DefaultSessionStartContext will be installed on PresentationServiceImpl. When both the default session and PresentationDispatcher's callback are available, the callback will be invoked with the session. On Reset(), if a callback is available, it will be invoked with null. Changed PresentationDispatcher to not update Blink in that case. Also, PSImpl now keeps track of the corresponding RFH's ID instead of RFH* since most of the time we only need to use the ID. Changed PresentationServiceDelegate's Add/RemoveObserver interface, since the PresentationServiceDelegate need to be able to correlate an Observer with a RFH. (at most 1 per RFH, as it stands today). Added OnDefaultPresentationStarted to PresentationServiceDelegate::Observer interface and implemented it in PresentationServiceImpl. Added tests in PresentationServiceImpl. BUG=459001 Committed: https://crrev.com/2ed5f820be60cfe8ef53f2e25605ae94bda8de0a Cr-Commit-Position: refs/heads/master@{#326859}

Patch Set 1 : Original patch #

Patch Set 2 : Fix the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -52 lines) Patch
M content/browser/presentation/presentation_service_impl.h View 5 chunks +38 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 12 chunks +82 lines, -30 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 1 9 chunks +99 lines, -12 lines 0 comments Download
M content/common/presentation/presentation_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/presentation_service_delegate.h View 2 chunks +19 lines, -5 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
imcheng (use chromium acct)
5 years, 8 months ago (2015-04-23 17:47:11 UTC) #2
mark a. foltz
lgtm
5 years, 8 months ago (2015-04-23 18:10:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055053004/60001
5 years, 8 months ago (2015-04-23 18:14:26 UTC) #7
imcheng (use chromium acct)
+Avi for content/public/browser/presentation_service_delegate.h
5 years, 8 months ago (2015-04-23 18:31:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58535)
5 years, 8 months ago (2015-04-23 18:53:28 UTC) #11
imcheng
Ping for Avi.
5 years, 8 months ago (2015-04-24 18:22:25 UTC) #13
Avi (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-24 18:40:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055053004/60001
5 years, 8 months ago (2015-04-24 18:42:00 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 8 months ago (2015-04-24 19:41:27 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 19:42:20 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ed5f820be60cfe8ef53f2e25605ae94bda8de0a
Cr-Commit-Position: refs/heads/master@{#326859}

Powered by Google App Engine
This is Rietveld 408576698