Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1055053003: Update {virtual,override} to follow C++11 style in dbus. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in dbus. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/0e1afc9112d09515b380002645efc21ba3a87122 Cr-Commit-Position: refs/heads/master@{#326451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M dbus/mock_object_proxy.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
satorux: please take a look
5 years, 8 months ago (2015-04-23 04:19:46 UTC) #2
satorux1
lgtm
5 years, 8 months ago (2015-04-23 04:32:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055053003/1
5 years, 8 months ago (2015-04-23 04:38:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 04:42:06 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 04:43:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e1afc9112d09515b380002645efc21ba3a87122
Cr-Commit-Position: refs/heads/master@{#326451}

Powered by Google App Engine
This is Rietveld 408576698