Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 105503011: Update FFmpegDemuxer unknown duration logic to work for video-only streams. (Closed)

Created:
6 years, 11 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Update FFmpegDemuxer unknown duration logic to work for video-only streams. The FFmpegDemuxer would only compute the duration at the end of playback for clips without a duration that contained audio. This was not being done for video-only streams which resulted inconsistent behavior. This change simply make the duration computation logic apply to all stream types. TEST=FFmpegDemuxerTest.Read_EndOfStream_NoDuration_VideoOnly, FFmpegDemuxerTest.Read_EndOfStream_NoDuration_AudioOnly Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243304

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M media/filters/ffmpeg_demuxer.cc View 1 chunk +12 lines, -11 lines 1 comment Download
M media/filters/ffmpeg_demuxer_unittest.cc View 4 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 11 months ago (2014-01-03 23:21:40 UTC) #1
xhwang
lgtm % a tiny nit https://codereview.chromium.org/105503011/diff/1/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/105503011/diff/1/media/filters/ffmpeg_demuxer.cc#newcode804 media/filters/ffmpeg_demuxer.cc:804: if (duration != kNoTimestamp() ...
6 years, 11 months ago (2014-01-04 01:12:38 UTC) #2
acolwell GONE FROM CHROMIUM
On 2014/01/04 01:12:38, xhwang wrote: > lgtm % a tiny nit > > https://codereview.chromium.org/105503011/diff/1/media/filters/ffmpeg_demuxer.cc > ...
6 years, 11 months ago (2014-01-04 02:39:26 UTC) #3
xhwang
lgtm++
6 years, 11 months ago (2014-01-07 01:23:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/105503011/1
6 years, 11 months ago (2014-01-07 09:51:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/105503011/1
6 years, 11 months ago (2014-01-07 15:28:50 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 16:15:09 UTC) #7
Message was sent while issue was closed.
Change committed as 243304

Powered by Google App Engine
This is Rietveld 408576698