Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1054983003: Revert of Implement IPC::ParamTraits<mojo::MessagePipeHandle> (Closed)

Created:
5 years, 8 months ago by mfomitchev
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement IPC::ParamTraits<mojo::MessagePipeHandle> (patchset #4 id:60001 of https://codereview.chromium.org/1051443003/) Reason for revert: This broke the tests again, looks like ParamTraitInvalidMesssagePipe was fixed, but ParamTraitValidMessagePipe wasn't. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/36687/steps/ipc_mojo_unittests/logs/IPCChannelMojoTest.ParamTraitValidMessagePipe https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/36687 Original issue's description: > Implement IPC::ParamTraits<mojo::MessagePipeHandle> > > This allows MessagePipeHandle to be an IPC message member. > Note that this assumes underlying channel being a ChannelMojo > and can be used in content/ only after ChannelMojo settles. > > BUG=448190 > TEST=IPCChannelMojoTest.ParamTrait* > R=viettrungluu@chromium.org > > Committed: https://crrev.com/5656ae68841a3e3ddaac75cf2983d9052d71d0d5 > Cr-Commit-Position: refs/heads/master@{#323265} > > Committed: https://crrev.com/2b85d21119ce534940ccd2ff57727cd4b428081c > Cr-Commit-Position: refs/heads/master@{#323370} TBR=viettrungluu@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448190 Committed: https://crrev.com/ef026b654f3e8e0d6f83114bf0f148b26a5cc1be Cr-Commit-Position: refs/heads/master@{#323484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -191 lines) Patch
M ipc/mojo/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 2 chunks +0 lines, -115 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ipc/mojo/ipc_mojo_param_traits.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ipc/mojo/ipc_mojo_param_traits.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mfomitchev
Created Revert of Implement IPC::ParamTraits<mojo::MessagePipeHandle>
5 years, 8 months ago (2015-04-02 14:49:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054983003/1
5 years, 8 months ago (2015-04-02 14:50:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 14:51:28 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:25:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef026b654f3e8e0d6f83114bf0f148b26a5cc1be
Cr-Commit-Position: refs/heads/master@{#323484}

Powered by Google App Engine
This is Rietveld 408576698