Make the ChromeOS GN debug component build work

Make the ChromeOS GN debug component build work.

This CL contains several fixes needed to make the ChromeOS GN debug component build link.

R=brettw@chromium.org, erg@chromium.org, garykac@chromium.org, kjellander@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg;tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg

Committed: https://crrev.com/6c395564651cc613d4b374f4d94fdeedf5a5141b
Cr-Commit-Position: refs/heads/master@{#327164}

[Dirk Pranke, 2015-04-23 01:17:29]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org, erg@google.com, garykac@chromium.org,
kjellander@chromium.org

[Dirk Pranke, 2015-04-23 01:19:17]

I don't actually like any of the fixes in this patch, so I would like to hear
suggestions from the reviewers on what the "right" fixes should be.

Thanks!

https://codereview.chromium.org/1054963007/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1054963007/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:218: "views/frame/opaque_browser_frame_view_linux.h",
these files get stripped out of ui_views_non_mac_sources in the gyp build
because :ui is a static_library, not a source set.

One potential fix for this is to move these files into a different variable and
only include those sources in the (is_linux && !is_chromeos) configurations.

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:90: ]
I don't understand why, but when these files are linked :host, linking
//chrome:main_dll fails, complaining that remoting::CurtainMode::Create is not
defined.

It seems like these files should perhaps be moved to a different variable that
is only included when enable_me2me_host==true.

I do not understand why this file isn't getting stripped out as dead code by the
linker, though, since :host is a static library.

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:153: "//third_party/libjingle:libjingle_webrtc",
libpeerconnection depends //third_party/libjingle:libjingle_webrtc_common , but
those files need someone to define the symbols provided in libjingle_webrtc
(overrides/init_webrtc). Perhaps libpeerconnection should depend on
libjingle_webrtc rather than libjingle_webrtc_common?

[kjellander_chromium, 2015-04-23 13:03:31]

kjellander@chromium.org changed reviewers:
+ tommi@chromium.org

[kjellander_chromium, 2015-04-23 13:03:31]

+tommi: Should we change libpeerconnection to depend on libjingle_webrtc instead
of libjingle_webrtc_common as Dirk suggests?

[Elliot Glaysher, 2015-04-23 17:12:22]

erg@chromium.org changed reviewers:
+ erg@chromium.org

[Elliot Glaysher, 2015-04-23 17:12:22]

lgtm

https://codereview.chromium.org/1054963007/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1054963007/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:218: "views/frame/opaque_browser_frame_view_linux.h",
On 2015/04/23 01:19:17, Dirk Pranke wrote:
> these files get stripped out of ui_views_non_mac_sources in the gyp build
> because :ui is a static_library, not a source set.
> 
> One potential fix for this is to move these files into a different variable
and
> only include those sources in the (is_linux && !is_chromeos) configurations.

I think that can wait until after we stop using gypi_to_gn.py.

[tommi (sloooow) - chröme, 2015-04-24 11:05:12]

On 2015/04/23 at 13:03:31, kjellander wrote:
> +tommi: Should we change libpeerconnection to depend on libjingle_webrtc
instead of libjingle_webrtc_common as Dirk suggests?

I would like to do that after the cleanup has been completed in the overrides
folder. I'd also prefer to keep the build files in sync.

[garykac, 2015-04-27 18:27:02]

lgtm

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:90: ]
On 2015/04/23 01:19:17, Dirk Pranke wrote:
> I don't understand why, but when these files are linked :host, linking
> //chrome:main_dll fails, complaining that remoting::CurtainMode::Create is not
> defined.
> 
> It seems like these files should perhaps be moved to a different variable that
> is only included when enable_me2me_host==true.

Agreed.  But that seems out of scope for this cl. Can you add a TODO comment
describing the issue?

[Dirk Pranke, 2015-04-27 19:52:25]

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1054963007/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:90: ]
On 2015/04/27 18:27:02, garykac wrote:
> Agreed.  But that seems out of scope for this cl. Can you add a TODO comment
> describing the issue?

Will do.

[Dirk Pranke, 2015-04-27 20:40:11]

Scott, can I get an OWNERS approval for chrome/browser/ui/BUILD.gn ?

https://codereview.chromium.org/1054963007/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1054963007/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:218: "views/frame/opaque_browser_frame_view_linux.h",
On 2015/04/23 17:12:22, Elliot Glaysher wrote:
> On 2015/04/23 01:19:17, Dirk Pranke wrote:
> > these files get stripped out of ui_views_non_mac_sources in the gyp build
> > because :ui is a static_library, not a source set.
> > 
> > One potential fix for this is to move these files into a different variable
> and
> > only include those sources in the (is_linux && !is_chromeos) configurations.
> 
> I think that can wait until after we stop using gypi_to_gn.py.

ok.

[Dirk Pranke, 2015-04-27 20:43:07]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[Dirk Pranke, 2015-04-27 20:43:08]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1054963007/#ps20001
(title: "review feedback - add comments w/ tracking bugs for dependency issues")

[Dirk Pranke, 2015-04-27 20:43:27]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2015-04-27 20:44:06]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[Dirk Pranke, 2015-04-27 20:44:06]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1054963007/#ps40001
(title: "add comment in //third_party/libjingle as well")

[commit-bot: I haz the power, 2015-04-27 20:44:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054963007/40001

[commit-bot: I haz the power, 2015-04-27 21:48:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 21:48:38]

Dry run: This issue passed the CQ dry run.

[sky, 2015-04-27 22:54:58]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-04-27 22:54:59]

LGTM

[Dirk Pranke, 2015-04-27 22:55:32]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-04-27 22:56:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054963007/40001

[commit-bot: I haz the power, 2015-04-27 22:57:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-27 22:58:57]

Patchset 3 (id:??) landed as
https://crrev.com/6c395564651cc613d4b374f4d94fdeedf5a5141b
Cr-Commit-Position: refs/heads/master@{#327164}