[turbofan] Introduce BranchMatcher and DiamondMatcher helpers.

[turbofan] Introduce BranchMatcher and DiamondMatcher helpers.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/13d6de49864c89318e8f877d4be55171c6e2d62a
Cr-Commit-Position: refs/heads/master@{#27613}

[Benedikt Meurer, 2015-04-07 07:19:01]

LGTM if nits are addressed. I generally don't like adding constructors with
logic, but I don't have a good way to fix this, except static constructor
methods, which are even worse.

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers.cc
File src/compiler/node-matchers.cc (right):

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers....
src/compiler/node-matchers.cc:51: if (input0->opcode() == IrOpcode::kIfFalse &&
Nit: Use else if.

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers....
src/compiler/node-matchers.h:564: bool IfProjsAreOwned() const {
Nit: Please rename to ProjectionsAreOwned() or IsPureDiamond() or something like
that.

[titzer, 2015-04-07 08:41:01]

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers.cc
File src/compiler/node-matchers.cc (right):

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers....
src/compiler/node-matchers.cc:51: if (input0->opcode() == IrOpcode::kIfFalse &&
On 2015/04/07 07:19:01, Benedikt Meurer wrote:
> Nit: Use else if.

Done.

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):

https://codereview.chromium.org/1054963002/diff/1/src/compiler/node-matchers....
src/compiler/node-matchers.h:564: bool IfProjsAreOwned() const {
On 2015/04/07 07:19:01, Benedikt Meurer wrote:
> Nit: Please rename to ProjectionsAreOwned() or IsPureDiamond() or something
like
> that.

Done.

[titzer, 2015-04-07 08:41:38]

The CQ bit was checked by titzer@chromium.org

[titzer, 2015-04-07 08:41:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1054963002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-04-07 08:41:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054963002/20001

[commit-bot: I haz the power, 2015-04-07 09:03:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 09:03:49]

Patchset 2 (id:??) landed as
https://crrev.com/13d6de49864c89318e8f877d4be55171c6e2d62a
Cr-Commit-Position: refs/heads/master@{#27613}