Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: pkg/observe/lib/src/path_observer.dart

Issue 105493003: workaround for event handlers: don't return StreamSubscription as model (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/polymer/CHANGELOG.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/observe/lib/src/path_observer.dart
diff --git a/pkg/observe/lib/src/path_observer.dart b/pkg/observe/lib/src/path_observer.dart
index bec7eb8b7b1a4238c9cd73401ea9cc71ca0a9549..5e59b80d1f592f1321a56d12e54686ca5478280b 100644
--- a/pkg/observe/lib/src/path_observer.dart
+++ b/pkg/observe/lib/src/path_observer.dart
@@ -334,9 +334,12 @@ bool _hasMethod(ClassMirror type, Symbol name) {
ClassMirror _safeSuperclass(ClassMirror type) {
try {
return type.superclass;
- } on UnsupportedError catch (e) {
- // TODO(jmesserly): dart2js throws this error when the type is not
+ } /*on UnsupportedError*/ catch (e) {
+ // Note: dart2js throws UnsupportedError when the type is not
// reflectable.
+ // TODO(jmesserly): dart2js also throws a NoSuchMethodError if the `type` is
+ // a bound generic, because they are not fully implemented. See
+ // https://code.google.com/p/dart/issues/detail?id=15573
return objectType;
}
}
« no previous file with comments | « no previous file | pkg/polymer/CHANGELOG.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698