Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1054913002: Web MIDI: do not manage connection state from embedder side (Closed)

Created:
5 years, 8 months ago by Takashi Toyoshima
Modified:
5 years, 8 months ago
Reviewers:
yhirano
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, toyoshim+midi_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: do not manage connection state from embedder side In the latest spec, each MIDIPort has two separate states. One is DeviceState, the other is ConnectionState. DeviceState represents the device being "connected" or "disconnected". ConnectionState represents the MIDIPort of each MIDIAccess actually being "open" the device or not. ConnectionState is managed in Blink. So, content implementation do not have to manage the state. In stead, it should manage actual MIDIAccess client counts that open the device. After this change, MIDI_PORT_DISCONNECTED: means the device is not connected to the system. MIDI_PORT_CONNECTED: means the device is connected to the system, but there are no actual clients that open the device. MIDI_PORT_OPEN: means the device is connected, and at least one client open the device. BUG=471793 Committed: https://crrev.com/7f47161c5246973e5ed615221e938eab359edfc0 Cr-Commit-Position: refs/heads/master@{#323487}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/media/midi_message_filter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/midi_message_filter_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Takashi Toyoshima
Not urgent, but to remove MIDIPortConnectionState::ConnectionStateOpen in Blink side.
5 years, 8 months ago (2015-04-02 09:32:09 UTC) #2
yhirano
lgtm
5 years, 8 months ago (2015-04-02 11:46:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054913002/20001
5 years, 8 months ago (2015-04-02 13:44:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 15:08:59 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:25:29 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f47161c5246973e5ed615221e938eab359edfc0
Cr-Commit-Position: refs/heads/master@{#323487}

Powered by Google App Engine
This is Rietveld 408576698