|
|
Created:
5 years, 8 months ago by sof Modified:
5 years, 8 months ago Reviewers:
jochen (gone - plz use gerrit), Sami, rmcilroy, haraken, kouhei (in TOK), alex clarke (OOO till 29th) CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFinalize scheduler before shutting down Blink.
Have the Blink unittest runner shutdown the scheduler before doing
same to Blink, as the former may well access objects in the latter.
R=kouhei,haraken
BUG=
Committed: https://crrev.com/12e3f839fe65a520ee0d1a0176110f8e05513ef0
Cr-Commit-Position: refs/heads/master@{#323453}
Patch Set 1 #Patch Set 2 : optionally shutdown scheduler #Messages
Total messages: 24 (10 generated)
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
The CQ bit was checked by kouhei@chromium.org
lgtm
The CQ bit was unchecked by kouhei@chromium.org
LGTM!
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054893002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
haraken@chromium.org changed reviewers: + jochen@chromium.org
Jochen: PTAL? We need to land this to fix oilpan builds.
jochen@chromium.org changed reviewers: + rmcilroy@chromium.org
the bots aren't happy? +ross for scheduler-foo
haraken@chromium.org changed reviewers: + alexclarke@chromium.org, skyostil@chromium.org
+sami, alex
On 2015/04/02 08:08:39, jochen wrote: > the bots aren't happy? > > +ross for scheduler-foo May not have a scheduler attached; added reqd null check.
lgtm
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/1054893002/#ps20001 (title: "optionally shutdown scheduler")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054893002/20001
On 2015/04/02 08:29:22, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1054893002/20001 Lgtm, thanks!
Thanks for fixing this. On Thu, Apr 2, 2015 at 10:08 AM, <rmcilroy@chromium.org> wrote: > On 2015/04/02 08:29:22, I haz the power (commit-bot) wrote: > >> CQ is trying da patch. Follow status at >> https://chromium-cq-status.appspot.com/patch-status/1054893002/20001 >> > > Lgtm, thanks! > > https://codereview.chromium.org/1054893002/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/12e3f839fe65a520ee0d1a0176110f8e05513ef0 Cr-Commit-Position: refs/heads/master@{#323453} |