Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1054893002: Finalize scheduler before shutting down Blink. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finalize scheduler before shutting down Blink. Have the Blink unittest runner shutdown the scheduler before doing same to Blink, as the former may well access objects in the latter. R=kouhei,haraken BUG= Committed: https://crrev.com/12e3f839fe65a520ee0d1a0176110f8e05513ef0 Cr-Commit-Position: refs/heads/master@{#323453}

Patch Set 1 #

Patch Set 2 : optionally shutdown scheduler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/test/test_blink_web_unit_test_support.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
kouhei (in TOK)
lgtm
5 years, 8 months ago (2015-04-02 07:07:56 UTC) #3
haraken
LGTM!
5 years, 8 months ago (2015-04-02 07:26:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054893002/1
5 years, 8 months ago (2015-04-02 07:27:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/53591)
5 years, 8 months ago (2015-04-02 07:37:05 UTC) #9
haraken
Jochen: PTAL? We need to land this to fix oilpan builds.
5 years, 8 months ago (2015-04-02 07:42:35 UTC) #11
jochen (gone - plz use gerrit)
the bots aren't happy? +ross for scheduler-foo
5 years, 8 months ago (2015-04-02 08:08:39 UTC) #13
haraken
+sami, alex
5 years, 8 months ago (2015-04-02 08:22:39 UTC) #15
sof
On 2015/04/02 08:08:39, jochen wrote: > the bots aren't happy? > > +ross for scheduler-foo ...
5 years, 8 months ago (2015-04-02 08:23:46 UTC) #16
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-02 08:28:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054893002/20001
5 years, 8 months ago (2015-04-02 08:29:22 UTC) #20
rmcilroy
On 2015/04/02 08:29:22, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-02 09:08:26 UTC) #21
chromium-reviews
Thanks for fixing this. On Thu, Apr 2, 2015 at 10:08 AM, <rmcilroy@chromium.org> wrote: > ...
5 years, 8 months ago (2015-04-02 09:21:57 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 10:01:45 UTC) #23
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:23:55 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12e3f839fe65a520ee0d1a0176110f8e05513ef0
Cr-Commit-Position: refs/heads/master@{#323453}

Powered by Google App Engine
This is Rietveld 408576698