Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1054883003: Ship ES6 computed property names (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship ES6 computed property names BUG=v8:3754 LOG=N R=dslomov@chromium.org, rossberg@chromium.org Committed: https://crrev.com/6244bbcd84a8ecab041efa4c8cdc9b7d55cd6516 Cr-Commit-Position: refs/heads/master@{#27676}

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
arv (Not doing code reviews)
PTAL The intent to ship email was sent out a month ago: https://groups.google.com/forum/#!topic/v8-users/mhX5JxAbe5M
5 years, 8 months ago (2015-04-02 14:47:27 UTC) #1
adamk
lgtm
5 years, 8 months ago (2015-04-02 15:33:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054883003/1
5 years, 8 months ago (2015-04-08 17:11:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4552)
5 years, 8 months ago (2015-04-08 17:12:54 UTC) #7
arv (Not doing code reviews)
git rebase
5 years, 8 months ago (2015-04-08 17:23:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054883003/20001
5 years, 8 months ago (2015-04-08 17:23:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 17:49:19 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 17:49:34 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6244bbcd84a8ecab041efa4c8cdc9b7d55cd6516
Cr-Commit-Position: refs/heads/master@{#27676}

Powered by Google App Engine
This is Rietveld 408576698