Editing - Code refactoring to avoid redundant function calls

Source/core/editing/FrameSelection.cpp

Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index 78d4dceb878763c5fc9c835d383fceabcddaf676..404afef0860f3dff318957e1889a9e5940f0b255 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -225,14 +225,14 @@ void FrameSelection::setSelection(const VisibleSelection& newSelection, SetSelec
     EUserTriggered userTriggered = selectionOptionsToUserTriggered(options);
 
     VisibleSelection s = newSelection;
-    if (shouldAlwaysUseDirectionalSelection(m_frame))
-        s.setIsDirectional(true);
-
     if (!m_frame) {
         m_selection = s;
         return;
     }
 
+    if (shouldAlwaysUseDirectionalSelection(m_frame))

[ojan, 2013/12/09 23:09:57]

Doesn't moving this change behavior since it affects the value of m_selection?

+        s.setIsDirectional(true);
+
     // <http://bugs.webkit.org/show_bug.cgi?id=23464>: Infinite recursion at FrameSelection::setSelection
     // if document->frame() == m_frame we can get into an infinite loop
     if (s.base().anchorNode()) {