Editing - Code refactoring to avoid redundant function calls

Editing - Code refactoring to avoid redundant function calls

Minor cleanup that I came across while working on other issues, to knock off redundant fucntion calls.
Also got rid of an unused variable.

TEST=No tests added since this is a refactoring.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163556

[vanihegde, 2013-12-09 07:54:33]

Minor change, please have a look. Thanks.

[yosin_UTC9, 2013-12-09 08:05:27]

ACK

Thanks!

[ojan, 2013-12-09 23:09:57]

https://codereview.chromium.org/105483003/diff/1/Source/core/editing/FrameSel...
File Source/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/105483003/diff/1/Source/core/editing/FrameSel...
Source/core/editing/FrameSelection.cpp:233: if
(shouldAlwaysUseDirectionalSelection(m_frame))
Doesn't moving this change behavior since it affects the value of m_selection?

[vanihegde, 2013-12-10 03:38:15]

> (shouldAlwaysUseDirectionalSelection(m_frame))
> Doesn't moving this change behavior since it affects the value of m_selection?

You are right, it does! I totally missed it. Will revert it.

[vanihegde, 2013-12-10 11:57:25]

Reverted FrameSelection changes.
Also added a change to get rid of redundant function calls.
Please have a look. Thanks!

[ojan, 2013-12-10 18:16:06]

lgtm

[commit-bot: I haz the power, 2013-12-10 18:16:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/105483003/40001

[commit-bot: I haz the power, 2013-12-10 19:10:30]

Change committed as 163556